.... lots more, from the shitty MRS code tree..... ERROR: space required before the open parenthesis '(' #1721: FILE: src/target/riscv/riscv-013.c:4248: + if((riscvchip==0x01)||(riscvchip==0x02)||(riscvchip==0x06)||(riscvchip==0x05)) WARNING: braces {} are not necessary for single statement blocks #1721: FILE: src/target/riscv/riscv-013.c:4248: + if((riscvchip==0x01)||(riscvchip==0x02)||(riscvchip==0x06)||(riscvchip==0x05)) { write_flash_data(target, address, size, count, buffer); } ERROR: Missing Signed-off-by: line(s) total: 1733 errors, 131 warnings, 1592 lines checked NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or scripts/cleanfile Your patch has style problems, please review. If any of these errors are false positives, please report them to the openocd-devel mailing list or prepare a patch and send it to Gerrit for review. error: failed to push some refs to 'github.com:karlp/openocd-hacks.git' karlp@strem:~/src/openocd-code (mrs-wch-riscv-220623 *)$